Fixes #39199 - Prevent spurious calls to the proxy related to pubkey/ca pubkey refresh#1026
Merged
ofedoren merged 2 commits intotheforeman:masterfrom Mar 31, 2026
Merged
Conversation
adamruzicka
changed the title
Member
|
Thanks, @adamruzicka, should we link this in Redmine / Jira before merging? :) Also rubocop is not happy :/ |
…ponses The previous "return stored value or fetch a fresh one if missing" approach used for pubkey and ca_pubkey could cause calls to the proxy in unexpected situations. This could lead to problems like not being able to list smart proxies if the proxy which didn't have one of the pubkey fields filled was down. This change more strictly separates when values are only read and when values can be updated as part of reading.
adamruzicka
force-pushed
the
optional-refresh
branch
from
b7e4b06 to
5c14ecb
Compare
Contributor
Author
Done
Rubocop is hard to please at times. Let's see what it thinks now |
adamruzicka
changed the title
ofedoren
approved these changes
Mar 31, 2026
Member
ofedoren
left a comment
ofedoren
left a comment
There was a problem hiding this comment.
Thanks, @adamruzicka, it fixes the issue and it also takes pubkey into consideration, so we won't face similar bug 🥇
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.