Fixes #38630 - Add expand all rows to table in job invocation detail#993
Merged
MariaAga merged 1 commit intotheforeman:masterfrom Oct 21, 2025
Merged
Conversation
kmalyjur
changed the title
ofedoren
changed the title
MariaAga
reviewed
Sep 25, 2025
Comment on lines
+326
to
+331
| const allAreExpanded = areAllPageRowsExpanded; | ||
|
|
||
| setExpandedHost(prevExpanded => { | ||
| const pageIdsSet = new Set(pageHostIds); | ||
|
|
||
| if (allAreExpanded) { |
Member
There was a problem hiding this comment.
const allAreExpanded = areAllPageRowsExpanded;
Is this const needed? can the code use areAllPageRowsExpanded?
MariaAga
reviewed
Sep 25, 2025
| const pageIdsSet = new Set(pageHostIds); | ||
|
|
||
| if (allAreExpanded) { | ||
| return prevExpanded.filter(hostId => !pageIdsSet.has(hostId)); |
Member
There was a problem hiding this comment.
if all expended I would expect that the new value of expandedHost will be just []
MariaAga
reviewed
Sep 25, 2025
| return prevExpanded.filter(hostId => !pageIdsSet.has(hostId)); | ||
| } | ||
|
|
||
| const newExpanded = new Set([...prevExpanded, ...pageHostIds]); |
Member
There was a problem hiding this comment.
and if its not expended than the new value will be just the page ids, not sure what is the prevExpanded purpose here?
Member
|
Foreman PR merged, this PR needs a rebase 🙏 |
Contributor
|
Please bump the |
kmalyjur
force-pushed
the
job-inv-expand-table-2
branch
from
3aa477f to
3d491ec
Compare
kmalyjur
force-pushed
the
job-inv-expand-table-2
branch
from
3d491ec to
496cd61
Compare
Contributor
Author
|
@MariaAga Thank you, could you please re-review? It's rebased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#10632 is needed for this PR