Fixes #38636 - JobInvocationHostTable doesnt load the template with auto reload#995
Conversation
|
I'm getting |
kmalyjur
force-pushed
the
job-inv-template-reload
branch
2 times, most recently
from
6871a94 to
e94db24
Compare
|
@MariaAga Thank you, fixed now |
|
The error doesnt happen, but the issue from the pr isnt resolved, if a user schedules a job for the future (2 mins) and stays on the page the table stays on |
|
@MariaAga I tested it exactly like how you described, and in my opinion, it works: |
| }, [allResponse]); | ||
|
|
||
| useEffect(() => { | ||
| if (finished && !refreshedOnFinish.current) { |
There was a problem hiding this comment.
Might be because your job goes immediately to finished and mine goes to running
There was a problem hiding this comment.
You're right! I changed it so it reloads when the status changes. Is that okay?
kmalyjur
force-pushed
the
job-inv-template-reload
branch
from
e94db24 to
020f338
Compare
|
Opening a job invocation in a new tab comes back empty |
kmalyjur
force-pushed
the
job-inv-template-reload
branch
from
020f338 to
3ed6a7a
Compare
|
@MariaAga I'm sorry, I tested it properly now, I hope. |
| isVisible, | ||
| hostName, | ||
| hostProxy, | ||
| isExpanded, |
There was a problem hiding this comment.
do we need a new prop? can we use just some isExpanded || !isInTableView?
There was a problem hiding this comment.
I changed it back to isExpanded
kmalyjur
force-pushed
the
job-inv-template-reload
branch
from
3ed6a7a to
6b8d3c8
Compare
|
@adamruzicka could you please merge it? |
3 participants
The index page now passes
finishedto theJobInvocationHostTable, and auseEffectis added to refetch the data whenfinishedbecomes true. I'm not sure if it's the best solution, even though it works as expected, so I'm open to new ideas.