Skip to content

Fixes #38698 - Missing host jobs in host details page#998

Merged
adamruzicka merged 1 commit intotheforeman:masterfrom
Lukshio:missing_jobs
Sep 9, 2025
Merged

Fixes #38698 - Missing host jobs in host details page#998
adamruzicka merged 1 commit intotheforeman:masterfrom
Lukshio:missing_jobs

Conversation

@Lukshio
Copy link
Copy Markdown
Contributor

@Lukshio Lukshio commented Aug 28, 2025

No description provided.

Copy link
Copy Markdown
Member

@ofedoren ofedoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Lukshio
Copy link
Copy Markdown
Contributor Author

Lukshio commented Aug 29, 2025

Don't we already have it a bit below? https://github.com/theforeman/foreman_remote_execution/pull/998/files#diff-959bc9abc46a55332bb64d5155a79323afa75a50ec1a2137ddd22d926f62c6c5R33

It's mathing React instead of that controller

@adamruzicka
Copy link
Copy Markdown
Contributor

Rather than declaring a single route twice in different places, couldn't we move get 'job_invocations/:id', to: 'react#index', as: 'job_invocation' below the resources :job_invocations block?

@kmalyjur
Copy link
Copy Markdown
Contributor

kmalyjur commented Sep 4, 2025

It fixes the issue. I'm not sure I know how Adam's proposal would work.

@Lukshio
Copy link
Copy Markdown
Contributor Author

Lukshio commented Sep 9, 2025

Rather than declaring a single route twice in different places, couldn't we move get 'job_invocations/:id', to: 'react#index', as: 'job_invocation' below the resources :job_invocations block?

Sure, thank you! Re-tested it, and it works well

@adamruzicka adamruzicka merged commit a798edb into theforeman:master Sep 9, 2025
25 checks passed
@adamruzicka
Copy link
Copy Markdown
Contributor

Thank you @Lukshio !

@Lukshio Lukshio deleted the missing_jobs branch October 20, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants