Skip to content

Conversation

@chris1984
Copy link
Member

@chris1984 chris1984 commented Sep 29, 2025

Summary by Sourcery

Refactor the InsightsTab component to use a hook, introduce a helper to detect missing insights facets and update tab visibility logic, add corresponding tests, and bump the release version to 12.2.9

Enhancements:

  • Refactor InsightsTab to use useAdvisorEngineConfig hook instead of response props and remove propTypes
  • Add hasNoInsightsFacet helper and integrate it into the Recommendations tab hide logic
  • Add informational log output in rh_cloud_inventory rake task when subscription connection is enabled

Tests:

  • Add tests for hasNoInsightsFacet in ForemanRhCloudHelpers

Chores:

  • Bump version to 12.2.9 in gemspec and package.json

@sourcery-ai
Copy link

sourcery-ai bot commented Sep 29, 2025

Reviewer's Guide

This release refactors the InsightsTab to use a hook for IOP mode detection, introduces a helper to check for missing insights facets and integrates it into the tab hiding logic, bumps the package version, and enhances inventory task logging.

File-Level Changes

Change Details Files
Refactor InsightsTab to useAdvisorEngineConfig hook
  • Replace response.insights_attributes.use_iop_mode prop with useAdvisorEngineConfig()
  • Update conditional rendering to use isLocalIop flag
  • Remove PropTypes and defaultProps related to response
webpack/InsightsHostDetailsTab/NewHostDetailsTab.js
Add hasNoInsightsFacet helper with tests
  • Define hasNoInsightsFacet to detect missing insights_attributes
  • Add unit tests and update snapshots for the new helper
webpack/ForemanRhCloudHelpers.js
webpack/__tests__/ForemanRhCloudHelpers.test.js
webpack/__tests__/__snapshots__/ForemanRhCloudHelpers.test.js.snap
Enhance tab hiding logic to include insights facet check
  • Import hasNoInsightsFacet in fills file
  • Update hideTab predicate to combine isNotRhelHost and hasNoInsightsFacet
webpack/ForemanRhCloudFills.js
Bump package version to 12.2.9
  • Update VERSION constant in version.rb
  • Update version in package.json
lib/foreman_rh_cloud/version.rb
package.json
Add conditional log for upload status in rake task
  • Insert puts message when subscription_connection_enabled setting is true
lib/tasks/rh_cloud_inventory.rake

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@chris1984 chris1984 merged commit cf9d151 into foreman_3_16 Sep 29, 2025
7 of 8 checks passed
@chris1984 chris1984 deleted the release6184 branch September 29, 2025 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants