i18n - pulling from tx #1109
Merged
i18n - pulling from tx #1109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's GuideThis PR updates i18n locale files by pulling fresh content from Transifex: it bumps version metadata, adds new translation keys and ‘Ignored when using local Insights.’ annotations, fills previously empty translations across all supported languages, and synchronizes .pot and .po files. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- Many new string entries are still empty across locales—please provide translations or a suitable fallback to prevent missing UI text.
- Ensure the added 'Ignored when using local Insights.' suffix is consistently and grammatically correct in each target language.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Many new string entries are still empty across locales—please provide translations or a suitable fallback to prevent missing UI text.
- Ensure the added 'Ignored when using local Insights.' suffix is consistently and grammatically correct in each target language.
## Individual Comments
### Comment 1
<location> `app/assets/javascripts/foreman_rh_cloud/locale/fr/foreman_rh_cloud.js:324` </location>
<code_context>
],
"Obfuscate host names": [
- "Obfusquer les noms d'hôtes"
+ "Masquer les noms d'hôtes"
],
"Obfuscate host names sent to the Red Hat cloud": [
</code_context>
<issue_to_address>
**question:** Inconsistent terminology for 'Obfuscate' in French translation.
Please review whether 'masquer' or 'obfusquer' best fits the technical meaning, as 'obfuscate' suggests anonymization rather than just hiding.
</issue_to_address>
### Comment 2
<location> `app/assets/javascripts/foreman_rh_cloud/locale/zh_CN/foreman_rh_cloud.js:38-40` </location>
<code_context>
],
"Analytics data collection": [
- ""
+ "数据收集分析"
],
"Any Organization": [
</code_context>
<issue_to_address>
**suggestion (typo):** Potential mistranslation of 'Analytics data collection' in Chinese.
The current translation changes the intended meaning. Please use "分析数据收集" or "分析数据的收集" for accuracy.
```suggestion
"Analytics data collection": [
"分析数据收集"
],
```
</issue_to_address>
### Comment 3
<location> `app/assets/javascripts/foreman_rh_cloud/locale/zh_CN/foreman_rh_cloud.js:321` </location>
<code_context>
],
"Obfuscate host ipv4 addresses.": [
- ""
+ "对主机 ipv4 地址进行模糊化处理"
],
"Obfuscate host names": [
</code_context>
<issue_to_address>
**suggestion:** Inconsistent translation for 'obfuscate' in Chinese locale.
Consider standardizing the translation to '混淆' or '匿名化' for technical accuracy, as '模糊' may suggest blurring rather than obfuscation.
</issue_to_address>
### Comment 4
<location> `app/assets/javascripts/foreman_rh_cloud/locale/ko/foreman_rh_cloud.js:146-148` </location>
<code_context>
],
"Exclude installed packages": [
- ""
+ "설치된 패키지 제외"
],
"Exclude installed packages from being uploaded to the Red Hat cloud": [
</code_context>
<issue_to_address>
**suggestion:** Translation for 'Exclude installed packages' in Korean may be ambiguous.
"설치된 패키지 제외" may imply that installed packages are already excluded, not that the user should take action. Alternatives like "설치된 패키지 제외하기" or "설치된 패키지 업로드 제외" would be clearer.
```suggestion
"Exclude installed packages": [
"설치된 패키지 업로드 제외"
],
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
app/assets/javascripts/foreman_rh_cloud/locale/zh_CN/foreman_rh_cloud.js
Show resolved
Hide resolved
parthaa
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Refresh and synchronize i18n locale files by pulling the latest translations from Transifex, update version metadata, and introduce new translation keys for local Insights context.
Enhancements:
Documentation: