Skip to content

Conversation

@chris1984
Copy link
Member

@chris1984 chris1984 commented Oct 7, 2025

Summary by Sourcery

Bump extension version and refresh translations across all locales; annotate many UI strings with “Ignored when using local Insights”; adjust CVECountCell to respect local Insights configuration by returning UnknownIcon when IoP is disabled or pending; and add tests covering the new conditional rendering logic.

Enhancements:

  • Return UnknownIcon in CVECountCell when local Insights is disabled or pending and only call API when IoP and subscription UUID are present

Build:

  • Bump foreman_rh_cloud gem and npm package version to 12.2.11

Tests:

  • Add tests covering CVECountCell behavior when IoP is disabled, undefined, or when API call fails

Chores:

  • Refresh Project-Id-Version metadata in all locale files to 13.0.5
  • Fill in missing translations and append “Ignored when using local Insights” to numerous locale keys in fr, ja, ko, zh_CN, ka

@sourcery-ai
Copy link

sourcery-ai bot commented Oct 7, 2025

Reviewer's Guide

Release 12.2.11 primarily refreshes localization files with updated versioning and translator info, integrates local Insights configuration into the CVECountCell component (with improved rendering and API call guarding), augments its unit tests for various Insights states, and performs a project version bump.

Class diagram for updated CVECountCell component

classDiagram
  CVECountCell <|-- React.Component
  CVECountCell : +hostDetails
  CVECountCell : +isIopEnabled
  CVECountCell : +uuid
  CVECountCell : +key
  CVECountCell : +response
  CVECountCell : +useAdvisorEngineConfig()
  CVECountCell : +useAPI()
  CVECountCell : +render()
  CVECountCell : -UnknownIcon
  CVECountCell : -Link
  CVECountCell : -insightsCloudUrl
  CVECountCell : vulnerabilityApiPath(path)
  CVECountCell : if (!isIopEnabled) return <UnknownIcon />
  CVECountCell : if (uuid === undefined) return <UnknownIcon />
Loading

File-Level Changes

Change Details Files
Localization: bump version and update translations across locale files
  • Bumped Project-Id-Version and Last-Translator in locale JS files for multiple languages
  • Added new translation keys with '. Ignored when using local Insights.' and placeholders
  • Populated or adjusted translation strings for various UI messages
app/assets/javascripts/foreman_rh_cloud/locale/*.js
locale/*.po
locale/foreman_rh_cloud.pot
Enhance CVECountCell to respect local Insights configuration
  • Imported useAdvisorEngineConfig and require isIopEnabled to fetch CVE data
  • Prefixed API call condition with isIopEnabled && uuid
  • Added fallback rendering to UnknownIcon when local Insights is disabled
webpack/InsightsVulnerabilityHostIndexExtensions/CVECountCell.js
Expand CVECountCell unit tests for IoP config and error handling
  • Mocked useAdvisorEngineConfig in beforeEach and cleared mocks in afterEach
  • Added test cases for no subscription UUID, IoP disabled, API failure, and pending state
  • Defined shared hostDetailsMock and adjusted assertions for UnknownIcon
webpack/InsightsVulnerabilityHostIndexExtensions/__tests__/CVECountCell.test.js
Bump project version to 12.2.11
  • Updated VERSION constant in version.rb
  • Incremented version field in package.json
lib/foreman_rh_cloud/version.rb
package.json

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@chris1984 chris1984 merged commit acb78ce into theforeman:foreman_3_16 Oct 7, 2025
6 of 8 checks passed
@chris1984 chris1984 deleted the 618snap5 branch October 7, 2025 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants