Skip to content

Conversation

@parthaa
Copy link
Collaborator

@parthaa parthaa commented Oct 8, 2025

What are the changes introduced in this pull request?

Fixes a typo from the previous uploader sh script
Previous Commit =>

What are the testing steps for this pull request?

  • Have a IoP setup with a few hosts
  • Apply pr
  • rm /var/lib/foreman/redhat_inventory/uploads/uploader.sh
  • Administer -> Inventory Upload -> Generate report
  • This should complete successfully
  • Then run the following query (assuming you are in default org you should see something like this.)
$ sudo -u postgres psql -d advisor_db -c "select id, org_id from inventory.hosts"
                  id                  |        org_id        
--------------------------------------+----------------------
 86870b59-e45c-4f4e-9b15-914a44af4dbd | Default_Organization
(1 row)

Note the same behavior can be reproduced by just registering a new host in a iop setup since the report upload runs on package profile upload

Summary by Sourcery

Bug Fixes:

  • Remove stray '+' from the ORG_HEADER assignment line in uploader.sh.erb

@sourcery-ai
Copy link

sourcery-ai bot commented Oct 8, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR corrects a shell syntax typo in the uploader.sh.erb script by removing an unintended '+' character from the ORG_HEADER assignment, restoring the intended header construction.

File-Level Changes

Change Details Files
Remove stray '+' from ORG_HEADER assignment
  • Deleted extraneous '+' character before the ORG_HEADER assignment
  • Preserved the original indentation and syntax for header construction
lib/foreman_inventory_upload/scripts/uploader.sh.erb

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@pablomh
Copy link

pablomh commented Oct 8, 2025

Fixes SAT-39109.

@parthaa parthaa merged commit e08d1ad into theforeman:develop Oct 8, 2025
24 checks passed
@parthaa parthaa deleted the uploader branch October 8, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants