-
Notifications
You must be signed in to change notification settings - Fork 21
Proxy features: REX #309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Proxy features: REX #309
Conversation
7100b9a to
c81b6c2
Compare
| name: foreman-proxy | ||
| state: restarted | ||
|
|
||
| - name: Refresh Foreman Proxy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This gets executed too early on fresh installs. Damn.
4b3451c to
64f8540
Compare
| name: foreman-proxy-remote_execution_ssh-ssh-key | ||
| path: /root/foreman-proxy-ssh | ||
| notify: | ||
| - Restart Foreman Proxy | ||
| - Refresh Foreman Proxy | ||
|
|
||
| - name: Create SSH Pub podman secret | ||
| containers.podman.podman_secret: | ||
| state: present | ||
| name: foreman-proxy-remote_execution_ssh-ssh-pub | ||
| path: /root/foreman-proxy-ssh.pub |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two tasks can be consolidated into a loop to create the SSH key/pub secrets, which will also ensure the handler runs only once, OR just run the handler when SSH secrets are mounted to the container
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Handlers run only once, no matter how often they are notified.
| - name: Create SSH Key podman secret | ||
| containers.podman.podman_secret: | ||
| state: present | ||
| name: foreman-proxy-remote_execution_ssh-ssh-key |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| name: foreman-proxy-remote_execution_ssh-ssh-key | |
| name: foreman-proxy-remote_execution_ssh-key |
922ca79 to
d103cc6
Compare
6d74c47 to
3ee17bd
Compare
|
theforeman/smart_proxy_remote_execution_ssh#128 dropped ssh-async mode , would you include this patch to keep the config file in sync 0001-Adjust-sp-rex-ssh-config-file-to-async-ssh-removal.patch ? |
3ee17bd to
194332a
Compare
|
theforeman/smart_proxy_remote_execution_ssh#126 added new settings for SSH certs, here is a patch that adds the new settings: diff --git a/src/roles/foreman_proxy/templates/settings.d/remote_execution_ssh.yml.j2 b/src/roles/foreman_proxy/templates/settings.d/remote_execution_ssh.yml.j2
index b7d6402..76ad344 100644
--- a/src/roles/foreman_proxy/templates/settings.d/remote_execution_ssh.yml.j2
+++ b/src/roles/foreman_proxy/templates/settings.d/remote_execution_ssh.yml.j2
@@ -11,6 +11,15 @@
# Mode of operation, one of ssh, pull, pull-mqtt
:mode: ssh
+# Enables the use of SSH certificate for smart proxy authentication
+# The file should contain an SSH CA public key that the SSH public key of smart proxy is signed by
+# :ssh_user_ca_public_key_file:
+
+# Enables the use of SSH host certificates for host authentication
+# The file should contain a list of trusted SSH CA authorities that the host certs can be signed by
+# Example file content: @cert-authority * <SSH CA public key>
+# :ssh_ca_known_hosts_file:
+
# Defines how often (in seconds) should the runner check
# for new data leave empty to use the runner's default
# :runner_refresh_interval: 1 |
this is suboptimal, as it means we do an additional restart, but it ensures the refresh works
194332a to
caf8416
Compare
|
@adamlazik1 thanks, applied |
|
What remains to be done here until this can be undrafted? |
eaf7e75 to
53daace
Compare
No description provided.