Refactor to better indicate the program flow#108
Open
ekohl wants to merge 1 commit intotheforeman:masterfrom
Open
Refactor to better indicate the program flow#108ekohl wants to merge 1 commit intotheforeman:masterfrom
ekohl wants to merge 1 commit intotheforeman:masterfrom
Conversation
In 9bf22c4 the option to run a script was added. By using the else branch it better indicates the flow of the program, making the comment describing it redundant.
Member
|
Based on conversations in theforeman/foremanctl#404 we may want to remove the script support. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In 9bf22c4 the option to run a script was added. By using the else branch it better indicates the flow of the program, making the comment describing it redundant.