Fixes #38330 - Set foreman_url in settings.yaml#1220
Merged
ehelms merged 1 commit intotheforeman:masterfrom Apr 4, 2025
Merged
Fixes #38330 - Set foreman_url in settings.yaml#1220ehelms merged 1 commit intotheforeman:masterfrom
ehelms merged 1 commit intotheforeman:masterfrom
Conversation
The foreman_url is already a parameter. It'd be more consistent if we enforced this in settings so users can't override it.
ehelms
approved these changes
Apr 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The foreman_url is already a parameter. It'd be more consistent if we enforced this in settings so users can't override it.
Should this be a backwards incompatible change given we'll override any user setting that previously existed? If so, should it also include a release note?