Avoid dependency cycles with glibc-langpack-en#1224
Merged
ekohl merged 1 commit intotheforeman:masterfrom May 9, 2025
Merged
Conversation
By calling stdlib::ensure_packages() in the class itself the resource gets tied to the class. If other packages also depend on the resource, you can get dependency cycles. In particular, candlepin also does this and that causes a dependency cycle. By using a class that is included the resource "floats" in the catalog. We then only ensure the package is installed somewhere before we create the database. Link: theforeman/puppet-candlepin@ca77145 Fixes: 768a54e ("Ensure glibc-langpack-en is always installed on EL")
evgeni
approved these changes
May 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By calling
stdlib::ensure_packages()in the class itself the resource gets tied to the class. If other packages also depend on the resource, you can get dependency cycles.In particular, candlepin also does this and that causes a dependency cycle.
By using a class that is included the resource "floats" in the catalog. We then only ensure the package is installed somewhere before we create the database.
Link: theforeman/puppet-candlepin@ca77145
Fixes: 768a54e ("Ensure glibc-langpack-en is always installed on EL")