Add openbolt plugin support#1249
Merged
bastelfreak merged 2 commits intotheforeman:masterfrom Dec 12, 2025
Merged
Conversation
1bceeea to
84944c1
Compare
ekohl
reviewed
Nov 28, 2025
ada1876 to
18ff8c9
Compare
ekohl
reviewed
Nov 29, 2025
70c6407 to
6c90db4
Compare
Member
Author
|
Member
Author
|
I'm checking if the dependency is intentional |
Member
Author
Member
Author
|
@ekohl the openbolt integration is working now. The acceptance tests fail because some other plugins are broken since a few days/weeks (mostly dynflow). Can we still merge this or do those plugins need to be fixed first? (if not too late, I would love to get this merged soonish so we can maybe get it into foreman 3.17). |
evgeni
reviewed
Dec 9, 2025
98f96bf to
eb50528
Compare
Member
Author
|
When running this locally, I get: |
Member
Author
|
another run: |
Member
Author
|
I can also reproduce the errors locally with beaker-vagrant |
eb50528 to
32cfc45
Compare
32cfc45 to
b9190dd
Compare
b9190dd to
ebcae91
Compare
Co-authored-by: Ewoud Kohl van Wijngaarden <ewoud@kohlvanwijngaarden.nl>
ebcae91 to
f59c39a
Compare
Member
|
I remember this was supposed to be included in 3.17.0. Ping me once we have all the pieces in place. I'll make sure we have this in 3.17.1. |
Member
Author
|
Yes will do. After the module is released, I will add support for the plugin into the installer. Afterwards it can be released as 3.17.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.