CI: Cleanup foreman installation before testing dynflow #1264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All acceptance tests run the cleanup, except for the dynflow test right now. This is probably because it's the first test. The specified cleanup always runs *before* the actual test, so this doesn't make sense for dynflow right now. In case someone adds another test file in spec/acceptance/ that starts with a,b or c, it will be executed before dynflow. To prevent failures in the future, we add the cleanup to dynflow, so others don't have to debug this for two weeks in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All acceptance tests run the cleanup, except for the dynflow test right now. This is probably because it's the first test. The specified cleanup always runs before the actual test, so this doesn't make sense for dynflow right now. In case someone adds another test file in spec/acceptance/ that starts with a,b or c, it will be executed before dynflow. To prevent failures in the future, we add the cleanup to dynflow, so others don't have to debug this for two weeks in the future.