Skip to content

Commit 712861d

Browse files
ekohlehelms
authored andcommitted
Add missing data types
The version in plugin.pp is stricter than foreman_proxy::globals but that's because you could declare an individual plugin with a specific version while globally it doesn't make sense to set a specific version number.
1 parent 2a33a2a commit 712861d

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

manifests/plugin.pp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@
77
# The package to install. Underscores are replaced with dashes on Debian
88
#
99
define foreman_proxy::plugin (
10-
$version = $foreman_proxy::params::plugin_version,
11-
$package = "${foreman_proxy::params::plugin_prefix}${title}",
10+
String[1] $version = $foreman_proxy::params::plugin_version,
11+
String[1] $package = "${foreman_proxy::params::plugin_prefix}${title}",
1212
) {
1313
# Debian gem2deb converts underscores to hyphens
1414
case $facts['os']['family'] {

manifests/proxydns.pp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,10 @@
1919
# entry.
2020
#
2121
class foreman_proxy::proxydns (
22-
$forwarders = $foreman_proxy::dns_forwarders,
23-
$interface = $foreman_proxy::dns_interface,
22+
Array[String] $forwarders = $foreman_proxy::dns_forwarders,
23+
String $interface = $foreman_proxy::dns_interface,
2424
Stdlib::Fqdn $forward_zone = $foreman_proxy::dns_zone,
25-
$reverse_zone = $foreman_proxy::dns_reverse,
25+
Optional[Variant[Boolean, String, Array[String]]] $reverse_zone = $foreman_proxy::dns_reverse,
2626
String $soa = $facts['networking']['fqdn'],
2727
) {
2828
class { 'dns':

manifests/remote_file.pp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
# @summary Downloads a file from a URL to a local file given by the title
22
# @api private
33
define foreman_proxy::remote_file (
4-
$remote_location,
5-
$mode='0644',
4+
Stdlib::Filesource $remote_location,
5+
Stdlib::Filemode $mode = '0644',
66
) {
77
$parent = dirname($title)
88
File <| title == $parent |>

0 commit comments

Comments
 (0)