Fixes #36957 - Expose Pulpcore content & api worker counts #467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
|
Small typo in commit message |
ehelms
reviewed
Jan 3, 2024
| postgresql_db_ssl_root_ca => $pulpcore_postgresql_ssl_root_ca, | ||
| worker_count => $pulpcore_worker_count, | ||
| django_secret_key => $pulpcore_django_secret_key, | ||
| content_service_worker_count => $pulpcore_content_service_worker_count, |
There was a problem hiding this comment.
Will this work properly? Right now this parameter requires an Integer
There was a problem hiding this comment.
Puppet always allows undef, which means "use whatever was underneath it".
These are parameters on the pulpcore module and allow further tuning without diving into Hiera.
ekohl
force-pushed
the
36957-expose-pulpcore-worker-count-parameters
branch
from
4cc75be to
f6a887e
Compare
ehelms
approved these changes
Jan 3, 2024
ekohl
changed the title
|
This this ready to go? @ekohl |
|
I'd still like to know if this is really needed. We try to avoid introducing options that nobody will use. I'm not convinced by theforeman/foreman-documentation#2565, mostly because of https://github.com/theforeman/foreman-documentation/pull/2565/files#r1440684234. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are parameters on the pulpcore module and allow further tuning without diving into Hiera.
This came up in theforeman/foreman-documentation#2565.
I still think most users shouldn't be touching this, so if our default tuning are poor we should modify them in puppet-pulpcore. That's why it defaults to undef, allowing us to change the tuning under the hood. If there was a default, it would be stored in the users' answer files.