Fix puppetserver ca sign with puppet 8.

[dforste]

Should fix #948

[bwitt]

None of the tests failed? Is this something that could be covered via tests?

[dforste]

@bwitt I have not written any tests for puppet in years.
A simple test if possible is:

• configure puppetserver
• Create a cert request (puppet agent [--certname NAME])
• Sing a cert request (puppetserver ca sign --certname NAME) (fails currently)

[jcpunk]

This fixes an issue I'm hitting with my puppet server. I don't see any tests for the existing puppet::server::ca==true case with auth.conf.

This should be pretty close for tests:

diff --git a/spec/classes/puppet_server_spec.rb b/spec/classes/puppet_server_spec.rb
index dd8907a..a5664f6 100644
--- a/spec/classes/puppet_server_spec.rb
+++ b/spec/classes/puppet_server_spec.rb
@@ -524,6 +524,11 @@ describe 'puppet' do
           it 'should not sync the crl' do
             should_not contain_file('/etc/custom/puppetlabs/puppet/ssl/crl.pem')
           end
+          it { should contain_file("#{conf_d_dir}/auth.conf").with_content(%r{path":\s*"/puppet-ca/v1/certificate_renewal"}) }
+          it { should contain_file("#{conf_d_dir}/auth.conf").with_content(%r{path":\s*"/puppet-ca/v1/certificate_status"}) }
+          it { should contain_file("#{conf_d_dir}/auth.conf").with_content(%r{path":\s*"/puppet-ca/v1/certificate_statuses"}) }
+          it { should contain_file("#{conf_d_dir}/auth.conf").with_content(%r{path":\s*"/puppet-ca/v1/sign"}) }
+          it { should contain_file("#{conf_d_dir}/auth.conf").with_content(%r{path":\s*"/puppet-ca/v1/sign/all"}) }
         end
       end

[bwitt]

@dforste I'm adding tests at dforste#1 ; how do those look?

[dforste]

Added both spec tests. Let me know if this is good enough.

[bwitt]

@dforste looks like we need a few more fixes dforste#2

[yakatz]

This fixes the issue for me - loading it directly and not waiting for a release. Thank you!

[dforste]

@ehelms do you think this is good enough to merge? Is there anything that might be missing? We ran into this when installing the latest openVox / Puppet 8.

[jcpunk]

Any chance for a new release with this pr?

[evgeni]

@jcpunk see #971