Skip to content

Allow dynflow-2.y.z #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ofedoren merged 3 commits into from
Jan 5, 2026
+7 −5
Merged

Allow dynflow-2.y.z #141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1c96344
Allow dynflow-2.y.z
adamruzicka Jan 5, 2026
42e411e
Require ruby >= 3.0
adamruzicka Jan 5, 2026
f8bb39b
Make rubocopy happy
adamruzicka Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/ruby.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ jobs:
rubocop:
name: Rubocop
uses: theforeman/actions/.github/workflows/rubocop.yml@v0
with:
ruby: 3.0

test:
name: Tests
Expand Down
4 changes: 2 additions & 2 deletions .rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ require:
- rubocop-rake

AllCops:
TargetRubyVersion: '2.7'
TargetRubyVersion: '3.0'

# Don't enforce documentation
Style/Documentation:
Expand Down Expand Up @@ -114,4 +114,4 @@ Layout/LineLength:
Max: 197

Style/SlicingWithRange:
Enabled: false
Enabled: false
2 changes: 1 addition & 1 deletion lib/smart_proxy_dynflow/api.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ class Api < ::Sinatra::Base

include ::Sinatra::Authorization::Helpers

TASK_UPDATE_REGEXP_PATH = %r{/tasks/(\S+)/(update|done)}.freeze
TASK_UPDATE_REGEXP_PATH = %r{/tasks/(\S+)/(update|done)}
Copy link
Member

@ofedoren ofedoren Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to make sure: is this due to Ruby 3.0 Regex objects should be frozen by default or it triggered an error?

Copy link
Contributor Author

@adamruzicka adamruzicka Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently it is an unnecessary noop

lib/smart_proxy_dynflow/api.rb:16:33: C: [Correctable] Style/RedundantFreeze: Do not freeze immutable objects, as freezing them has no effect.
      TASK_UPDATE_REGEXP_PATH = %r{/tasks/(\S+)/(update|done)}.freeze
                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^


before do
if match = request.path_info.match(TASK_UPDATE_REGEXP_PATH)
Expand Down
4 changes: 2 additions & 2 deletions smart_proxy_dynflow.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@ Gem::Specification.new do |gem|
gem.require_paths = ["lib"]
gem.license = 'GPL-3.0-only'

gem.required_ruby_version = '>= 2.7', '< 4'
gem.required_ruby_version = '>= 3.0'

gem.add_runtime_dependency('dynflow', "~> 1.6")
gem.add_runtime_dependency('dynflow', '>= 1.6', '< 3.0')
gem.add_runtime_dependency('rest-client', '~> 2.0')
gem.add_runtime_dependency('sqlite3', '~> 1.0')

Expand Down