Improve join robustness #35
Conversation
lib/smart_proxy_realm_ad/provider.rb
Outdated
| end | ||
|
|
||
| def retry_authentication_error(enroll) | ||
| MAX_RETRIES.times do |i| |
There was a problem hiding this comment.
This looks really good to me and much better than (dsnpl@a18ce9c88e321ad6399b884e87388fcb5ce57a74)[my attempt] -
I found that with multiple DCs requests get sequentially round-robined and that the set password request after the create create object request goes to a different DC that hasnt had the new object synced to it. Retrying for up to about 10 seconds sorts this out for me.
|
Ping @ekohl |
martencassel
force-pushed
the
join_robustness
branch
from
940692a to
0da5e3b
Compare
ekohl
left a comment
ekohl
left a comment
There was a problem hiding this comment.
This PR does a few things. Would you mind separating it into smaller PR? Preferably start with the CI updates
There was a problem hiding this comment.
For CI we've introduced a common workflow but not app plugins have adopted it. I'd prefer to do that. https://github.com/theforeman/actions?tab=readme-ov-file#smart-proxy-plugin-test has an example
Dockerfile
Outdated
| @@ -0,0 +1,6 @@ | |||
| FROM ruby:2.7 | |||
There was a problem hiding this comment.
We are in the process of dropping Ruby 2.7. If we introduce a container I'd prefer it to use Ruby 3
martencassel
force-pushed
the
join_robustness
branch
from
0da5e3b to
bd3a949
Compare
3 participants
This PR will attempt to improve join robustness and handle the cases of
Handling
#22
#27
#20