✨ properly propagate errors from nested scopes #1014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem where raising errors within nested scopes was causing the outermost delimiter to have its outcome overwritten by its children propagating up. This changes delimiters so that their outcomes cannot be overwritten unless that outcome is, in fact, an error.
commit: |
jbolda
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There was a problem where raising errors within nested scopes was causing the outermost delimiter to have its outcome overwritten by its children propagating up.
fixes #1013
Approach
This changes delimiters so that their outcomes cannot be overwritten unless that outcome is, in fact, an error.