Bring the website back into this repository #1028
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
cowboyd
reviewed
Sep 4, 2025
Member
cowboyd
left a comment
cowboyd
left a comment
There was a problem hiding this comment.
Can we put AGENTS.md into a .agents or something? I'd like to maintain root dir hygiene if possible
cowboyd
reviewed
Sep 4, 2025
Member
Author
@cowboyd unfortunately, according to https://agents.md, it has to be in the root.
|
Member
|
taras
force-pushed
the
tm/import-www
branch
2 times, most recently
from
638af3e to
8edb999
Compare
cowboyd
force-pushed
the
tm/import-www
branch
from
0e668c3 to
f8f1ebd
Compare
cowboyd
approved these changes
Dec 15, 2025
cowboyd
force-pushed
the
tm/import-www
branch
from
c30dfe1 to
ed3223e
Compare
auto-merge was automatically disabled
December 15, 2025 16:21
Pull request was closed
We brought it out because of tooling concerns. We're bringing it back in because it makes it so much easier to work on
cowboyd
force-pushed
the
tm/import-www
branch
from
ed3223e to
b3019e8
Compare
Member
|
Checks appear borked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We wanted to bring the website back into effection repository since Deno now supports having multiple projects in one repository. In the process, we also added the ability to render the website by reading content from git repositories instead of via GitHub API.
Approach
It was actually quite a bit of work to be able to read content from git repositories, but it looks like the result was worth while. I'll explain how it works. There are 2 primary abstractions to do most of the heavy lifting,
Fetch API
The fetch API is based on middleware. I was originally going to use
@effectionx/context-apibut I couldn't because the website uses effection 3, so I copy and pasted it into this repository. The fetch API provides the base abstraction for reading contents from URLs. This is helpful when we need to read data from GitHub API or GitHub website URLs. For example, JSR references GitHub respository URLs. By using the fetch context API, we're able to use a standard interface for fetching data and configure that interface separately.Repository
Repository is an abstraction for working with repositories. There are two kinds: Git and Octokit. Git read from the file system and Octokit from GitHub API. Both providers are available for reading files, but only Git provider is used for reading files. Octokit provider is used for fetching stars. We should really publish the Git API as a separate package.