Do not bind SIGTERM in Windows for v4 #1032
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additionaly: * use ctrlc-windows to terminate processes in Windows in tests
…ent line endings (LF) across all platforms, which should fix the "Text differed by line endings" error in CI.
commit: |
taras
force-pushed
the
tm/no-sigterm-windows-v4
branch
2 times, most recently
from
51c1ad5 to
1bb0911
Compare
taras
force-pushed
the
tm/no-sigterm-windows-v4
branch
from
1bb0911 to
92c07de
Compare
taras
force-pushed
the
tm/no-sigterm-windows-v4
branch
from
01fe54e to
6eb26da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Same as in #1031