Closed
Conversation
f2bcade to
e5a9854
Compare
Member
|
This feels like a scoping problem however. Why not just restrict the scope of the process to be within that of the test? If the test scope is outliving the deno test process, then it seems to me like we have a bug in the test adapter, no? |
Member
Author
|
it occurred to me that it might be a test adapter bug. essentially, we have processes that are not finished their cleanup when tests finished. it seems to happen when an asssetion is at the end of the test (which is the case in almost all tests) but it only shows itself with complex async operations and only with v4, v3 seems very stable. i'll take a look at the test adapter to see if anything jumps out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Watch tests are flaky because they spawn processes but they don't wait for those processes to finish. They eventually get cleaned up but in v4, they clean up after deno test finishes. Although, we didn't want to have an explicity kill on process to nudge people to rely on implicit cancellation, explicit
killis helpful in situations where you need to force kill as I do here.Approach
Add a kill function to process.