exports and ESM for foundation resolution with pnpm#303
Merged
Conversation
Member
Package Changes Through 1a2894dThere are 2 changes which include @simulacrum/foundation-simulator with patch, @simulacrum/github-api-simulator with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
commit: |
cowboyd
approved these changes
Feb 18, 2025
taras
approved these changes
Feb 18, 2025
c5e9ee7 to
1a2894d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
pnpmwas not properly resolving the Foundation simulator.Approach
Updating config to match the GitHub simulator as that appeared to correctly resolve. The root cause appeared to be that, even though the
exports.developmentwasn't used, if it pointed to files that didn't exist then it struggled. Included thesrcto resolve this issue.