Skip to content

Comments

exports and ESM for foundation resolution with pnpm#303

Merged
jbolda merged 3 commits intomainfrom
fnd-fix-pnpm-resolution
Feb 19, 2025
Merged

exports and ESM for foundation resolution with pnpm#303
jbolda merged 3 commits intomainfrom
fnd-fix-pnpm-resolution

Conversation

@jbolda
Copy link
Member

@jbolda jbolda commented Feb 18, 2025

Motivation

pnpm was not properly resolving the Foundation simulator.

Error: Failed to resolve entry for package "@simulacrum/foundation-simulator". The package may have incorrect main/module/exports specified in its package.json.
  Plugin: vite:import-analysis

Approach

Updating config to match the GitHub simulator as that appeared to correctly resolve. The root cause appeared to be that, even though the exports.development wasn't used, if it pointed to files that didn't exist then it struggled. Included the src to resolve this issue.

@frontsidejack
Copy link
Member

frontsidejack commented Feb 18, 2025

Package Changes Through 1a2894d

There are 2 changes which include @simulacrum/foundation-simulator with patch, @simulacrum/github-api-simulator with patch

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
@simulacrum/foundation-simulator 0.3.0 0.3.1
@simulacrum/github-api-simulator 0.5.3 0.5.4

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 18, 2025

Open in Stackblitz

npm i https://pkg.pr.new/thefrontside/simulacrum/@simulacrum/foundation-simulator@303
npm i https://pkg.pr.new/thefrontside/simulacrum/@simulacrum/github-api-simulator@303

commit: 1a2894d

@jbolda jbolda marked this pull request as ready for review February 18, 2025 03:57
@jbolda jbolda force-pushed the fnd-fix-pnpm-resolution branch from c5e9ee7 to 1a2894d Compare February 19, 2025 01:20
@jbolda jbolda merged commit 9187998 into main Feb 19, 2025
5 checks passed
@jbolda jbolda deleted the fnd-fix-pnpm-resolution branch February 19, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants