-
Notifications
You must be signed in to change notification settings - Fork 20
skip asset minification, remove String.raw
#349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Package Changes Through 22c2a21There are 4 changes which include @simulacrum/server with minor, @simulacrum/auth0-simulator with patch, @simulacrum/github-api-simulator with patch, @simulacrum/foundation-simulator with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
commit: |
This change addresses an issue with the auth0 simulator asset minification that was causing some views to break.
String.raw
cowboyd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, but let's see if we can delay a merge until we confirm a working preview.
|
The path for the Frontside logo was also broken with the path changes. @cowboyd I added a screenshot of it working. |
Motivation
This resolves #344. With the switch to
tsdown, the minification and handling ofString.rawchanged the view response and escaped characters.Approach
Remove minification and
String.rawusage; neither is required.Screenshot
/loginworking again using the preview package, e.g.npx https://pkg.pr.new/thefrontside/simulacrum/@simulacrum/auth0-simulator@22c2a21.