Skip to content

Fix #1773 #2250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thegrb93 merged 2 commits into from
Jan 28, 2026
Merged

Fix #1773 #2250

thegrb93 merged 2 commits into from
Jan 28, 2026
+1 −0

Conversation

@Astralcircle
Copy link
Contributor

@Astralcircle Astralcircle commented Jan 28, 2026 •
edited
Loading

Finally a good solution that fixes #1773

Disables rendering in reflections, mirrors and rt cameras

@Astralcircle
Fix thegrb93#1773
bdfdb54 
Finally a good solution for it
@thegrb93
Copy link
Owner

thegrb93 commented Jan 28, 2026 •
edited
Loading

Nice. I wonder if just if render.GetRenderTarget() then return end would be best though. Since we don't want rt cameras to render it either.

@thegrb93
Copy link
Owner

thegrb93 commented Jan 28, 2026

Also would move the check here: https://github.com/Astralcircle/StarfallEx/blob/bdfdb5486e009a80c9098c069609d97c4aa8faef/lua/entities/starfall_screen/cl_init.lua#L126

@thegrb93 thegrb93 merged commit 01a6a3d into thegrb93:master Jan 28, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thegrb93 thegrb93 thegrb93 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Starfall screen will render twice per frame if map has water

2 participants

@Astralcircle @thegrb93