Make getPrintName give "nice" text #2252
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thegrb93
approved these changes
Jan 30, 2026
Owner
thegrb93
left a comment
thegrb93
left a comment
There was a problem hiding this comment.
I think I'm fine with this unless anyone else has an issue with it
Contributor
|
Expose |
Contributor
Author
true |
Contributor
Author
|
There should be full language.Add support so public starfalls can be auto-translated into the user's language. But the issue is that it could possibly be abused to change already existing language.Adds that aren't local to starfall. |
Owner
|
Translations can be implemented in user code anyway using a simple table. |
Contributor
Author
True, but using gmod's translation would make it so you wouldn't have to make a translation table yourself. |
Contributor
Author
|
I might try making a language.add implementation that only works with starfall-created translations |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The title explains it. This fix automatically translates the print name. ex: #HL2_Crowbar -> CROWBAR