Skip to content

Abstract string functions to support both mbstring and native#39

Open
wyrfel wants to merge 1 commit intomasterfrom
feature/string-functions
Open

Abstract string functions to support both mbstring and native#39
wyrfel wants to merge 1 commit intomasterfrom
feature/string-functions

Conversation

@wyrfel
Copy link
Contributor

@wyrfel wyrfel commented Dec 12, 2019

No description provided.

@wyrfel wyrfel force-pushed the feature/string-functions branch from 9b4993a to 81d3028 Compare December 12, 2019 12:58
@wyrfel wyrfel self-assigned this Dec 15, 2019
@wyrfel wyrfel force-pushed the feature/string-functions branch from 81d3028 to 14c9327 Compare December 15, 2019 18:06
@coveralls
Copy link

Coverage Status

Coverage decreased (-4.2%) to 95.756% when pulling 14c9327 on feature/string-functions into 9a54a71 on master.

@ejegg
Copy link

ejegg commented Oct 21, 2022

I'd really like to see this fixed - we've started using the library at the Wikimedia Foundation for parsing donor names, and Irish donors who write their name 'Someone Ó Something' are coming out with broken unicode.
wyrfel do you want to pick this back up? If you don't have time right now, I'd be happy to make my own fork and add the required test coverage on top of this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants