Additional salutations and custom addition method#45
Open
jamessampford wants to merge 8 commits intotheiconic:masterfrom
Open
Additional salutations and custom addition method#45jamessampford wants to merge 8 commits intotheiconic:masterfrom
jamessampford wants to merge 8 commits intotheiconic:masterfrom
Conversation
wyrfel
suggested changes
May 21, 2020
Contributor
wyrfel
left a comment
wyrfel
left a comment
There was a problem hiding this comment.
Hi @jamessampford . Thanks for this PR. I would like to merge the added salutations, but not the custom salutation methods. The reasoning is that the NameParser already allows the passing of several custom language extension classes. You should really use that mechanism instead. It is also much more flexible as those custom classes can e.g. source the definitions from configuration files, data stores etc. .
eileenmcnaughton
added a commit
to eileenmcnaughton/name-parser
that referenced
this pull request
Mar 2, 2024
This picks up from theiconic#54 and theiconic#45 but only the additional prefixes & suffixes - not the logic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a few extra salutations as per #42 and also provided some additional methods to add custom salutations in that do not already exist
I was wondering if perhaps some salutations could be standardised - I've added a few examples into the list [Professor => Prof; Reverend => Rev; Pastor => Pr]
Additional ones could potentially pick up Doctor and transform it to Dr, Father to Fr, etc