Support for writing extra fields. #51
Open
+33
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
OMG my old co-worker just made a pull request to my best friend ❤️ |
Owner
|
Hi @acg . Sorry for the delayed response. (wow it's been 5 years.) Thanks for the high-quality PR! updating docs and tests is definitely appreciated. I'm curious which extra fields you want to include in the zip file, or if you want to perhaps preserve all of them that exist in an existing zip file? If the latter, this sounds similar to #38 and #76 . If you're interested in specific extra fields, the test changes suggest that perhaps the 0x7875 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change lets callers add tagged extra fields to central directory records. For compatibility with
yauzl, the shape ofextraFieldsis the same: anArraywith each entry of the form{id: id, data: data}.