fix working directory alteration#8
Open
hoangnv735 wants to merge 1 commit intothelinhbkhn2014:masterfrom
Open
Conversation
Fix working directory alteration when initializing VnCoreNLP
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix working directory alteration when initializing VnCoreNLP.
When creating a
VnCoreNLPinstance, the working directory is changed tosave_dir. This behavior cause errors when using with some package like Flask or Hydra.After loading the annotation model, I added a line to change it back to
self.current_working_dirto fix.I have tried some workaround to avoid changing the working directory, but I finally realized that the Java code of VnCoreNLP load models by related path. So I guess working directory alteration is inevitable now.
Below is the Java code from VnCoreNLP