fix: guard IMPISPAWBHist declaration for platforms that support it#17
Merged
fix: guard IMPISPAWBHist declaration for platforms that support it#17
Conversation
IMPISPAWBHist is not defined in T40/T41 SDK headers. Guard the IMP_ISP_Tuning_GetAwbHist prototype with the same platform condition used at the call site in imp_hal.cpp. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
IMPISPAWBHistis not defined in T40/T41 SDK headers (only present in T20/T21/T23/T30/T31/C100). The prototype declaration inimp_hal.hppwas unconditional, causing a compile error when building for T41.Fix
Guard the
IMP_ISP_Tuning_GetAwbHistprototype with the same platform condition already used at the call site inimp_hal.cpp:Tested
Build verified for
vanhua_z66si_t41nq_gc4023_eth(T41 SoC).