Skip to content

Conversation

@encukou
Copy link

@encukou encukou commented Feb 25, 2025

Hi! Here are my suggestions for the docs of python#129293. Merge this to update your PR.

  • break out the tuple fields into a list, like AF_TIPC or AF_CAN
  • define the referenced constants to avoid "missing target" warnings

(Ideally we'd merge allll the socket constant definitions with the usage documentation, so links go to informative text, but that's for a separate PR.)


📚 Documentation preview 📚: https://cpython-previews--1.org.readthedocs.build/

@themadinventor
Copy link
Owner

Much better, thanks!

@themadinventor themadinventor merged commit 05de5ee into themadinventor:gh-129288 Feb 25, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants