Skip to content

feat(Dropdown): add onToggle prop and update handlers for dropdown #1626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(Dropdown): add onToggle prop and update handlers for dropdown #1626

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions apps/storybook/src/Dropdown.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,3 +129,17 @@ ItemClickHandler.args = {
</>
),
};

export const onToggleHandler = Template.bind({});
onToggleHandler.storyName = "onToggle handlers";
onToggleHandler.args = {
onToggle: action("Dropdown toggled"),
children: (
<>
<DropdownItem onClick={action("Dashboard!")}>Dashboard</DropdownItem>
<DropdownItem onClick={action("Settings!")}>Settings</DropdownItem>
<DropdownItem onClick={action("Earnings!")}>Earnings</DropdownItem>
<DropdownItem onClick={action("Sign out!")}>Sign out</DropdownItem>
</>
),
};
28 changes: 22 additions & 6 deletions packages/ui/src/components/Dropdown/Dropdown.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ export interface DropdownTheme {

export interface DropdownProps
extends Pick<FloatingProps, "placement" | "trigger">,
Omit<ButtonProps, keyof ThemingProps<DropdownTheme>>,
Omit<ButtonProps, keyof ThemingProps<DropdownTheme> | "onToggle">,
ThemingProps<DropdownTheme> {
arrowIcon?: boolean;
dismissOnClick?: boolean;
Expand All @@ -54,6 +54,7 @@ export interface DropdownProps
label?: ReactNode;
enableTypeAhead?: boolean;
renderTrigger?: (theme: DropdownTheme) => ReactElement;
onToggle?: (open: boolean) => void;
"data-testid"?: string;
}

Expand Down Expand Up @@ -130,6 +131,7 @@ export function Dropdown(props: DropdownProps) {
dismissOnClick = true,
enableTypeAhead = true,
renderTrigger,
onToggle,
...restProps
} = resolveProps(props, provider.props?.dropdown);

Expand All @@ -143,10 +145,21 @@ export function Dropdown(props: DropdownProps) {
} = restProps;
const dataTestId = restProps["data-testid"] || "flowbite-dropdown-target";

const handleSelect = useCallback((index: number | null) => {
setSelectedIndex(index);
setOpen(false);
}, []);
const handleOpenChange = useCallback(
(newOpen: boolean) => {
setOpen(newOpen);
onToggle?.(newOpen);
},
[onToggle],
);

const handleSelect = useCallback(
(index: number | null) => {
setSelectedIndex(index);
handleOpenChange(false);
},
[handleOpenChange],
);

const handleTypeaheadMatch = useCallback(
(index: number | null) => {
Expand All @@ -161,7 +174,10 @@ export function Dropdown(props: DropdownProps) {

const { context, floatingStyles, refs } = useBaseFLoating<HTMLButtonElement>({
open,
setOpen,
setOpen: (value) => {
const newOpen = typeof value === "function" ? value(open) : value;
handleOpenChange(newOpen);
},
placement,
});

Expand Down
Loading