feat: Add flag to disable the replaceState in scrollspy#133
Open
arnoldknott wants to merge 1 commit intothemeselection:mainfrom
Open
feat: Add flag to disable the replaceState in scrollspy#133arnoldknott wants to merge 1 commit intothemeselection:mainfrom
arnoldknott wants to merge 1 commit intothemeselection:mainfrom
Conversation
…d to a new destination
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discussion
Adresses #130
Functionality
Allows turning off the replaceState through a flag in scrollspy to mitigate warning in Svelte.
Changes made
I have added the option
[--scrollspy-replace-history:false]as a flag similar to[--scrollspy-offset], and an if-statement, to skip the replaceState().A working code for the scrollspy area then looks like this, when this new flag is in use - here combined with the offset-flag:
Potential enhancements
Further enhancements of this could be to add an option for pushState and scrolling to the correct destination after a following popState.
Please let me know, what you think - I'd be happy to make changes and adopt to your thoughts. 🙏