-
Notifications
You must be signed in to change notification settings - Fork 82
Course card v4 #2288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 4.0.0-dev
Are you sure you want to change the base?
Course card v4 #2288
Conversation
…rresponding templates
…nsistency across course templates
… improved rendering
… deprecated files
…pdate markup for announcement notice
…bundle course badge
| 'spinner', | ||
| 'spreadsheet', | ||
| 'star', | ||
| 'star2', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The star.svg icon file was deleted but here the type start2 is deleted.
Maybe the star-2.svg should have been deleted.
| <?php if ( $price_data->sale_price ) : ?> | ||
| <span><?php tutor_print_formatted_price( $price_data->display_price ); ?></span> | ||
| <del><?php tutor_print_formatted_price( $price_data->regular_price ); ?></del> | ||
| <span class="tutor-text-small tutor-font-medium tutor-text-primary"><?php tutor_print_formatted_price( $price_data->display_price ); ?></span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this function is called in admin side then this classes will not work. Please double check.
| ?> | ||
| <div class="tutor-course-pagination"> | ||
| <?php | ||
| tutor_load_template_from_custom_path( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use Pagination Component.
| ?> | ||
| <div class="<?php echo esc_attr( $utility_classes ); ?>"> | ||
| <div class="list-item-price tutor-d-flex tutor-align-center"> | ||
| <div class="tutor-d-flex tutor-align-center"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please consider using latest classes.
| <div class="tutor-course-thumbnail"> | ||
| <a href="<?php the_permalink(); ?>" class="tutor-d-block"> | ||
| <div class="tutor-course-thumbnail tutor-card--padding-small"> | ||
| <a href="<?php the_permalink(); ?>" class="tutor-d-block tutor-position-relative"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use tutor-block
| } | ||
|
|
||
| .tutor-course-pagination { | ||
| .tutor-pagination { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use class utility for this.
| @import './offcanvas'; | ||
| @import './certificate-template'; // to be moved | ||
| @import './password-field'; | ||
| @import './card'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need this if we do not load old styles at all
No description provided.