-
Notifications
You must be signed in to change notification settings - Fork 82
Course Wishlist #2304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Course Wishlist #2304
Conversation
…space and adding comments
templates/dashboard/wishlist.php
Outdated
| $per_page = tutor_utils()->get_option( 'pagination_per_page', 20 ); | ||
| $current_page = max( 1, Input::get( 'current_page', 1, Input::TYPE_INT ) ); | ||
| $offset = ( $current_page - 1 ) * $per_page; | ||
| $wishlist_per_page = tutor_utils()->get_option( 'pagination_per_page', 20 ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add int typecast.
templates/dashboard/wishlist.php
Outdated
|
|
||
| $wishlists = tutor_utils()->get_wishlist( null, $offset, $per_page ); | ||
| $wishlists = tutor_utils()->get_wishlist( null, $offset, $wishlist_per_page ); | ||
| $total_wishlists_count = count( tutor_utils()->get_wishlist( null ) ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to pass null param
templates/dashboard/wishlist.php
Outdated
| </div> | ||
| <?php else : ?> | ||
| <?php tutor_utils()->tutor_empty_state( tutor_utils()->not_found_text() ); ?> | ||
| <?php EmptyState::make()->title( 'No Courses Found' )->render(); ?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Translate it.
…ndling for better performance and user experience
No description provided.