Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| bool CheckSpawnPoint(const Vector3& origin, const Vector3& mins, const Vector3& maxs, Vector3 gravityVector) { | ||
| trace_t tr; | ||
|
|
||
| if (!mins || !maxs) | ||
| return false; |
There was a problem hiding this comment.
Align spawn helper signatures with declarations
CheckSpawnPoint now requires a gravity vector here, but g_local.hpp and existing callers still declare/use the legacy three-parameter version (e.g., g_local.hpp:4577, m_medic.cpp:1046, m_carrier.cpp:314). The old symbol is therefore left undefined at link time and the new overload is never reached, so the game DLL will not build until the header and call sites are updated (the same mismatch exists for the patched FindSpawnPoint/CheckGroundSpawnPoint signatures).
Useful? React with 👍 / 👎.
Summary
Testing
Codex Task