Clamp domination tick interval and log clamping#601
Clamp domination tick interval and log clamping#601themuffinator wants to merge 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| g_domination_tick_interval_storage.value = -1.0f; | ||
| g_domination_tick_interval_storage.integer = -1; | ||
| const GameTime minimumInterval = DominationTickInterval(); | ||
| assert(minimumInterval == kDominationMinScoreInterval); | ||
| assert(!g_comPrintMessages.empty()); |
There was a problem hiding this comment.
Minimum interval test asserts unreachable clamp
The new minimum clamp assertions will always fail: DominationTickInterval() only uses g_domination_tick_interval when its value is positive (lines 26–32 of g_domination.cpp), so setting the cvar to -1 falls back to the 1 s default and never hits the minimum clamp/log path. The expectations here that the interval equals kDominationMinScoreInterval and that a "minimum" log was emitted are therefore unreachable, breaking this test every run.
Useful? React with 👍 / 👎.
Summary
Testing
Codex Task