Skip to content

Fix menu rendering compilation issues#633

Open
themuffinator wants to merge 1 commit intomainfrom
codex/fix-type-conversion-errors-in-menu_main.cpp-bnk7xm
Open

Fix menu rendering compilation issues#633
themuffinator wants to merge 1 commit intomainfrom
codex/fix-type-conversion-errors-in-menu_main.cpp-bnk7xm

Conversation

@themuffinator
Copy link
Owner

Summary

  • remove incompatible ranges pipelines in the menu renderer and rebuild visible entry selection iteratively
  • declare the game import interface before inline helpers to fix compilation
  • adjust berserk melee attack setup to use a non-constexpr aim vector with documentation

Testing

  • not run (not requested)

Codex Task

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

} };

extern cvar_t* g_gametype;
extern local_game_import_t gi;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P0 Badge Declare local_game_import_t before using in gi extern

extern local_game_import_t gi; is now placed before local_game_import_t is declared anywhere in the header, so any translation unit including this file fails to compile with an unknown-type error. The extern needs to come after the struct definition or be preceded by a forward declaration to keep the header buildable.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant