Generalize M_CheckBottom for arbitrary gravity vectors#686
Generalize M_CheckBottom for arbitrary gravity vectors#686themuffinator merged 1 commit intomainfrom
Conversation
This change generalizes M_CheckBottom_Fast_Generic and M_CheckBottom_Slow_Generic to support gravity vectors along any major axis (X, Y, Z), addressing a FIXME in the codebase. Previously, these functions assumed gravity was always vertical (Z-axis). - Updated M_CheckBottom_Fast_Generic and M_CheckBottom_Slow_Generic signatures to take a gravity direction vector instead of a ceiling boolean. - Implemented logic to determine the major gravity axis and adjust collision checks accordingly. - Updated calls in g_monster_spawn.cpp and M_CheckBottom to pass the gravity vector.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
1 participant
Addressed a FIXME in
src/server/monsters/m_move.cppwhere monster ground/ceiling checks were hardcoded to the Z-axis.Changes:
M_CheckBottom_Fast_GenericandM_CheckBottom_Slow_Genericto accept aVector3 gravityDirand handle gravity along any cardinal axis.M_CheckBottomto pass the entity's gravity vector.src/server/g_local.hppdeclarations.src/server/gameplay/g_monster_spawn.cppto construct a gravity vector for legacy calls.PR created automatically by Jules for task 6836469772156686735 started by @themuffinator