Safe Client Initialization and Cleanup#689
Conversation
- Modified `src/server/gameplay/g_clients.cpp` to prevent engine crashes by redirecting `gentity_t::client` pointers to a static dummy client in `FreeClientArray` instead of setting them to `nullptr`. - Replaced `memset` with default assignment for the dummy client to ensure safe handling of non-trivial C++ members in `gclient_t`. - Added `tests/test_g_clients_lifecycle.cpp` to verify client pointer handling.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
1 participant
This change addresses potential engine crashes during server shutdown or map changes by ensuring that entity client pointers always point to valid memory (a static dummy client) rather than null. This is crucial for systems like
SV_CalcPingsthat may access client data asynchronously or during cleanup. It also ensures safe object lifecycle management forgclient_tby using C++ assignment instead ofmemset.PR created automatically by Jules for task 7970426158536105784 started by @themuffinator