feat(testcontainers): Add a working testcontainers implementation #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a first implementation of the testcontainers support that covers basically all of the compliance tests. The get_client() method is still commented out, as the client itself is not yet implemented as testing the client depends on this being merged. Signed-off-by: Raphael Höser <[email protected]>
2 tasks
goloroden
previously approved these changes
May 6, 2025
Signed-off-by: Raphael Höser <[email protected]>
dotKuro
reviewed
May 7, 2025
|
First of all: Thanks for the contribution! 😊 I think it already looks really good. I just left a comment about a single thing I am unsure about. Maybe @goloroden has an answer to this? |
Signed-off-by: Raphael Höser <[email protected]>
dotKuro
approved these changes
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a first implementation of the testcontainers support that covers basically all of the compliance tests.
The get_client() method is still commented out, as the client itself is not yet implemented as testing the client depends on this being merged.