feat: support for read-event-type #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raphael Höser <[email protected]>
Snapstromegon
changed the title
goloroden
requested changes
Jul 29, 2025
There was a problem hiding this comment.
Hi @Snapstromegon 👋
Vielen Dank für diesen PR, der sieht (wie immer) super aus 🎉
Eigentlich hätte ich nur noch eine winzige Kleinigkeit: Könntest Du bitte noch einen kurzen Abschnitt in der README.md ergänzen, im Prinzip so wie hier (das kannst Du als Vorlage für die Formulierungen nehmen)?
Das wäre toll ❤️
Signed-off-by: Raphael Höser <[email protected]>
goloroden
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is right now incomplete - tests and readme docs are still missing