Skip to content

Conversation

Copy link

Copilot AI commented Nov 3, 2025

The rand 0.9 upgrade introduced a rand_core version mismatch: rand 0.9 uses rand_core 0.9, while ed25519-dalek 2.2.0 requires rand_core 0.6. This caused trait incompatibility errors when generating signing keys.

Changes

  • Add rand_core 0.6 as optional dependency with getrandom feature
  • Replace rand::thread_rng() with rand_core::OsRng in container.rs
  • Update testcontainer feature to include dep:rand_core

This maintains compatibility with both rand 0.9 and ed25519-dalek's rand_core 0.6 requirement.

// Before
use rand::prelude::ThreadRng;
let mut rng: ThreadRng = rand::thread_rng();
self.signing_key = Some(SigningKey::generate(&mut rng));

// After
use rand_core::OsRng;
self.signing_key = Some(SigningKey::generate(&mut OsRng));

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] Make requested changes to #72 Fix rand 0.9 compatibility by using rand_core 0.6 for key generation Nov 3, 2025
Copilot AI requested a review from goloroden November 3, 2025 05:54
Copilot finished work on behalf of goloroden November 3, 2025 05:54
@goloroden goloroden closed this Nov 3, 2025
@goloroden goloroden deleted the copilot/sub-pr-72 branch November 3, 2025 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants