Skip to content

Fix rand 0.9 compatibility by using rand_core 0.6 for key generation #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix rand 0.9 compatibility by using rand_core 0.6 for key generation #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a46b24
Initial plan
Copilot Nov 3, 2025
270cb19
Fix build issue with rand 0.9 upgrade by using rand_core::OsRng
Copilot Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ categories = ["database"]
[features]
default = []
cloudevents = ["dep:cloudevents-sdk"]
testcontainer = ["dep:testcontainers", "dep:rand", "ed25519-dalek/rand_core"]
testcontainer = ["dep:testcontainers", "dep:rand", "dep:rand_core", "ed25519-dalek/rand_core"]

[dependencies]
chrono = { version = "0.4.42", features = ["serde"] }
Expand All @@ -41,6 +41,7 @@ sha2 = "0.10.9"
hex = "0.4.3"
ed25519-dalek = { version = "2.2.0", features = ["rand_core", "pkcs8", "pem"] }
rand = { version = "0.9", optional = true }
rand_core = { version = "0.6", features = ["getrandom"], optional = true }

[dev-dependencies]
testcontainers = { version = "0.25.2", features = ["http_wait"] }
Expand Down
5 changes: 2 additions & 3 deletions src/container.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ use ed25519_dalek::{
SigningKey, VerifyingKey,
pkcs8::{EncodePrivateKey, spki::der::pem::LineEnding},
};
use rand::prelude::ThreadRng;
use rand_core::OsRng;
use testcontainers::{
ContainerAsync, CopyDataSource, GenericImage,
core::{ContainerPort, ImageExt, WaitFor, wait::HttpWaitStrategy},
Expand Down Expand Up @@ -115,8 +115,7 @@ impl ContainerBuilder {
/// The private key will be used to sign events and the public key will be used to verify them.
#[must_use]
pub fn with_signing_key(mut self) -> Self {
let mut rng: ThreadRng = rand::thread_rng();
self.signing_key = Some(SigningKey::generate(&mut rng));
self.signing_key = Some(SigningKey::generate(&mut OsRng));
self
}

Expand Down
Loading