feat(client): add metadata and discovery compliance matching#8
Merged
Conversation
This implementation is incomplete and lacking tests Signed-off-by: Raphael Höser <raphael@hoeser.info>
Snapstromegon
added a commit
that referenced
this pull request
May 13, 2025
#8 Signed-off-by: Raphael Höser <raphael@hoeser.info>
Signed-off-by: Raphael Höser <raphael@hoeser.info>
Contributor
Author
|
I'm aware that this will conflict with #7, but I will rebase/merge it after that one is merged. |
dotKuro
pushed a commit
that referenced
this pull request
May 15, 2025
…vents" compliance criteria (#7) * feat(client): add writing events to client adhering to the "Writing Events" compliance criteria * feat(client): rework write events based on forward looking learnings in #8 Signed-off-by: Raphael Höser <raphael@hoeser.info> * chore(client): restructure event module to avoid allowing clippy warnings --------- Signed-off-by: Raphael Höser <raphael@hoeser.info>
Contributor
Author
|
Intentionally moved this to draft again, until #9 is merged, to avoid problems with that much smaller PR, that will also make this PR easier to review. |
Signed-off-by: Raphael Höser <raphael@hoeser.info>
Signed-off-by: Raphael Höser <raphael@hoeser.info>
dotKuro
approved these changes
May 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implementation is incomplete and lacking tests