Same signer may not confirm different blocks of the same number

Author: dmugtasimov

node/blockchain/migrations/0005_blockconfirmation.py

@@ -0,0 +1,29 @@
+# Generated by Django 3.2.12 on 2022-03-19 10:07
+
+import uuid
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('blockchain', '0004_pendingblock'),
+    ]
+
+    operations = [
+        migrations.CreateModel(
+            name='BlockConfirmation',
+            fields=[
+                ('_id', models.UUIDField(default=uuid.uuid4, primary_key=True, serialize=False)),
+                ('number', models.PositiveBigIntegerField()),
+                ('hash', models.CharField(max_length=128)),
+                ('signer', models.CharField(max_length=64)),
+                ('body', models.BinaryField()),
+            ],
+            options={
+                'ordering': ('number', 'signer'),
+                'unique_together': {('number', 'signer')},
+            },
+        ),
+    ]

node/blockchain/models/block_confirmation.py

@@ -14,8 +14,8 @@ class BlockConfirmation(CustomModel):
     body = models.BinaryField()
 
     class Meta:
-        unique_together = ('number', 'hash', 'signer')
+        unique_together = ('number', 'signer')
         ordering = unique_together
 
     def __str__(self):
-        return f'block_number={self.number}, hash={self.hash}, signer={self.signer}'
+        return f'block_number={self.number}, signer={self.signer}, hash={self.hash}'

node/blockchain/tasks/process_block_confirmations.py

@@ -0,0 +1,17 @@
+from celery import shared_task
+
+# from node.blockchain.facade import BlockchainFacade
+
+
+@shared_task
+def process_block_confirmations_task():
+    # TODO(dmu) CRITICAL: Implement https://thenewboston.atlassian.net/browse/BC-272
+    # facade = BlockchainFacade.get_instance()
+    # next_block_number = facade.get_next_block_number()
+    # get all confirmation for next block number
+    # if there is no 2/3
+    raise NotImplementedError
+
+
+def start_process_block_confirmations_task():
+    process_block_confirmations_task.delay()

node/blockchain/views/block_confirmation.py

@@ -21,9 +21,15 @@ def create(self, request, *args, **kwargs):
 
         ORMBlockConfirmation.objects.update_or_create(
             number=block_confirmation.get_number(),
-            hash=block_confirmation.get_hash(),
             signer=block_confirmation.signer,
-            body=block_confirmation.json(),  # TODO(dmu) LOW: Pick request body as is instead
+            defaults={
+                'hash': block_confirmation.get_hash(),
+                'body': block_confirmation.json(),  # TODO(dmu) LOW: Pick request body AS IS instead
+            },
         )
 
+        # TODO(dmu) CRITICAL: https://thenewboston.atlassian.net/browse/BC-272
+        # if next block number and we have enough confirmations then run a celery task
+        # to add the block to the blockchain
+
         return Response(serializer.data, status=status.HTTP_201_CREATED)