Conversation
WalkthroughAdds Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@packages/models/src/models/google.ts`:
- Around line 663-664: The deprecation timeline is inverted for the Google model
entries: the deprecatedAt (new Date("2026-01-23")) is after deactivatedAt (new
Date("2026-01-15")), which violates the expected deprecatedAt <= deactivatedAt
ordering; locate the object(s) that set the deprecatedAt and deactivatedAt
properties (look for the entries with property names deprecatedAt and
deactivatedAt in packages/models/src/models/google.ts, including the second
occurrence around lines noted in the comment) and fix by making deprecatedAt
on-or-before deactivatedAt (e.g., swap the two dates or adjust deprecatedAt to
"2026-01-15" or deactivatedAt to "2026-01-23" as appropriate for the true
timeline).
- Gemini 2.5 Flash Image Preview: deactivated Jan 15, 2026 - Gemini 2.0 Flash & Flash Lite: deactivated Mar 31, 2026 - Azure GPT-4o Mini: deactivated Mar 31, 2026 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- google: fix gemini-2.0-flash deprecatedAt to 2026-01-22 - google: fix gemini-2.0-flash-lite deprecatedAt to 2026-01-22 - google: add deprecatedAt 2025-12-04 for gemini-2.5-flash-image-preview - openai: fix azure gpt-4o-mini deprecatedAt to 2026-01-09 - anthropic: fix claude-3-5-haiku-20241022 deprecatedAt to 2025-12-19 - xai: add deprecation for grok-3-mini (2026-01-30 / 2026-02-28) - xai: update grok-2-vision-1212 deprecation (2026-01-30 / 2026-02-28) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
9e30f1c to
b14bedc
Compare
Keep original dates (2025-08-08 / 2025-09-15) for grok-2-vision-1212 as they were previously set by Luca. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
| webSearch: true, | ||
| webSearchPrice: 0.01, // $10 per 1000 searches | ||
| deprecatedAt: new Date("2026-01-21"), | ||
| deprecatedAt: new Date("2025-12-19"), |
There was a problem hiding this comment.
this date is coming from their changelog
The gemini-2.5-flash-image-preview model is now deactivated (2026-01-15), so the test needs to explicitly request deactivated models. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
|
||
| test("GET /v1/models should include proper output modalities for gemini-2.5-flash-image-preview", async () => { | ||
| const res = await app.request("/v1/models"); | ||
| const res = await app.request("/v1/models?include_deactivated=true"); |
There was a problem hiding this comment.
@steebchen @smakosh Can you check this please if this change is OK?
The test is looking for gemini-2.5-flash-image-preview model and expects it to be defined. However, since this model now has deactivatedAt: 2026-01-15 (which is in the past - we're on 2026-02-04), the model is likely being filtered out by default. To fix it, need to add this filter include_deactivated
There was a problem hiding this comment.
This issue happened for gemini-2.5-flash-image-preview earlier
There was a problem hiding this comment.
ah good yeah that's the correct fix
Summary
Update deprecation and deactivation dates for retiring models based on official provider announcements.
Model Deprecation Summary
deprecatedAtdeactivatedAtgpt-4o-minigemini-2.0-flashgemini-2.0-flash-litegemini-2.5-flash-image-previewclaude-3-5-haiku-20241022grok-3-minigrok-2-vision-1212Sources
Test plan
pnpm buildpasses🤖 Generated with Claude Code
Summary by CodeRabbit