fix: watchdog for SSE + fix streaming messages in fallback #205 #206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
guillaume-sncfconnect
commented
Dec 19, 2025
guillaume-sncfconnect
commented
- Add a watchdog and a retry mechanism if SSE detected a lost pings
- Fix the message display for stream's messages with multiple chunks when fallback from SSE to HTTP
Fabilin
reviewed
Jan 7, 2026
|
|
||
| private tryOpen(url: string, resolve: () => void, reject: () => void) { | ||
| this.eventSource = new EventSource(url); | ||
| private tryOpen( resolve?: () => void, reject?: () => void) { |
Member
There was a problem hiding this comment.
Could you run lint on updated files?
| }); | ||
|
|
||
| // If the message is new, add it to the messages | ||
| // We can have multiple messages with the same responseId, but we only want to add the last one (chunks when streaming is disabled) |
Member
There was a problem hiding this comment.
Only if TOCK_STREAM_RESPONSE is enabled on this response!
| } | ||
|
|
||
| // Set a watchdog timeout to trigger a retry if the server is not responding | ||
| private scheduleRetryWatchdog({reason}: {reason: string}) { |
Member
There was a problem hiding this comment.
is it useful to have named parameters for a private method?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.